Prefer Object.keys over Ember.keys #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ define("ember/load-initializers", | |||
| 'default': function(app, prefix) { | |||
| var regex = new RegExp('^' + prefix + '\/((?:instance-)?initializers)\/'); | |||
|
|
|||
| Ember.keys(requirejs._eak_seen).map(function (moduleName) { | |||
| Object.keys(requirejs._eak_seen).map(function (moduleName) { | |||
There was a problem hiding this comment.
Lets fall back if not present (this will keep us in line with whatever Ember version is being used).
jmurphyau
force-pushed
the
remove-ember-keys
branch
2 times, most recently
from
81bbcb1
to
0cab2bf
Compare
jmurphyau
force-pushed
the
remove-ember-keys
branch
from
0cab2bf
to
7e94d56
Compare
jmurphyau
force-pushed
the
remove-ember-keys
branch
from
7e94d56
to
78470be
Compare
stefanpenner
added a commit
that referenced
this pull request
Jun 25, 2015
Prefer Object.keys over Ember.keys
|
Just tagged v0.1.5, can you update ember-cli default app blueprint? |
jmurphyau
added a commit
to jmurphyau/ember-cli
that referenced
this pull request
Jun 25, 2015
Removes Ember.keys deprecations (ember-cli/ember-load-initializers#18)
quaertym
pushed a commit
to quaertym/ember-cli
that referenced
this pull request
Jul 3, 2015
Removes Ember.keys deprecations (ember-cli/ember-load-initializers#18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.